Skip to content

Using NCC to build dist - #427

Open
Piotr Karpala (karpikpl) wants to merge 5 commits into
Azure:masterfrom
karpikpl:master
Open

Using NCC to build dist#427
Piotr Karpala (karpikpl) wants to merge 5 commits into
Azure:masterfrom
karpikpl:master

Conversation

@karpikpl

@karpikpl Piotr Karpala (karpikpl) commented Jun 24, 2024

Copy link
Copy Markdown

This PR introduces NCC to build distributable package, so that node_modules are no longer required in the repo.

It follows solution from https://github.com/Azure/login

@karpikpl
testing NCC
dfeb748 
Signed-off-by: Piotr Karpala <piotrkarpala@microsoft.com>
@karpikpl
fix action yml
8b6fb93
@karpikpl
updates to actions
500278c
@karpikpl

Piotr Karpala (karpikpl) commented Jun 24, 2024

Copy link
Copy Markdown
Author

Just noticed it copies the work done in #425 with the main difference that I deleted old lib files

@josh-hemphill

Jo (josh-hemphill) commented Feb 4, 2025

Copy link
Copy Markdown

Rooting for this PR, seems the cleanest. Really need one to get merged since it makes it possible to use in GHE.
Piotr Karpala (@karpikpl) Any chance for an update of the fork to get the checks passing? In the hope that the maintainers will approve this. 🤞

@karpikpl

Piotr Karpala (karpikpl) commented Feb 5, 2025

Copy link
Copy Markdown
Author

Rooting for this PR, seems the cleanest. Really need one to get merged since it makes it possible to use in GHE. Piotr Karpala (@karpikpl) Any chance for an update of the fork to get the checks passing? In the hope that the maintainers will approve this. 🤞

I can try, it's been a while when I created it.
This is really needed because this action is very slow without it

@karpikpl

Piotr Karpala (karpikpl) commented Feb 5, 2025

Copy link
Copy Markdown
Author

Hey Akshay Kumar (@kumaraksh1) Surender Singh Malik (@surenderssm) would you be able to review this?

@surenderssm

Surender Singh Malik (surenderssm) commented Feb 5, 2025

Copy link
Copy Markdown
Member

Tagging Shilpi Rachna (@ShilpiRachna1) to take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraksh1 Akshay Kumar (kumaraksh1) Awaiting requested review from kumaraksh1 kumaraksh1 is a code owner
@surenderssm Surender Singh Malik (surenderssm) Awaiting requested review from surenderssm surenderssm is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karpikpl @josh-hemphill @surenderssm